Opened 4 years ago

Closed 4 years ago

#13 closed defect (wontfix)

Useless lines in EasyList conversion

Reported by: linux@… Owned by:
Priority: minor Component:
Version: 1.3 Keywords:
Cc: Project: adblock2privoxy

Description

In output of the easylist in ab2p.action is::

# 450x55.jpg| (easylist.txt: 6318)
/.*450x55\.jpg$
.*450x55.jpg

The first line (after comment) IMO has useless '$' mark at end, but it can be in discussion. But second line is useless at all, because it lascks the path separator (/), it is treated as host (domain) name and will block all domains which ends with "450x55.jpg".

IMO only one line is enough:

/.*450x55.jpg

It must end with blocking all requestts for all domains, where path contains "450x55.jpg"

Another example is:

# ://bwp.*/search (easylist.txt: 5392)
/.*://bwp\..*/search
bwp.*./(.*/)?search

Here is opposite situation. I think, thet the ':/ /' (added space due formatting) is part of schema (http|https|ftp), but no matter this, the path separator (/) at start denotes, that the ":/ /" is part of the path and IMO it never happens and then this line is useless too.

regards

Change History (2)

comment:1 Changed 4 years ago by zubr

The main idea of adblock2privoxy is to emulate behaviour of adblock as fully as possible. And rules like 450x55.jpg will DO block domains containing "450x55.jpg" in adblock. You can check it yourself.

It is pity that rules authors didn't use something like ?*450x55.jpg to clearly define that 450x55 can only occur in parameters, not in domain. But they use more simple and ambiguous rules, and adblock2privoxy doesn't try to guess what did they mean. It just includes all possible cases.

The same I can say for the second case: authors could use ||bwp.*/search syntax, but they didn't.

comment:2 Changed 4 years ago by zubr

  • Resolution set to wontfix
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.