Opened 4 years ago

Closed 3 years ago

#9 closed defect (fixed)

rule starting with || not properly converted

Reported by: astewart1@… Owned by: zubr
Priority: major Component:
Version: Keywords: v1.2.4 win32
Cc: Project: adblock2privoxy

Description

ab2p.action contains conversions like

# ||a-static.com^$third-party (easylist_noelemhide.txt: 6650)
.*a-static.com

An ABP rule with a double-pipe should only match a full domain name, but for sites like lifehacker.com that use content from kinja-static.com, which shouldn't be blocked, are broken. I've hit a few other places over-blocked, too.

The Privoxy rule should be

.a-static.com

This is the conversion that some other bash scripts do. Privoxy docs say

if the host pattern starts or ends with a dot, it becomes unanchored at that end.

.example.com

    matches any domain with first-level domain com and second-level domain example. For example www.example.com, example.com and foo.bar.baz.example.com. Note that it wouldn't match if the second-level domain was another-example.

Thanks for the windows utility (via Siderite's blog). I'm using it with this bug post-processed out. Looking forward to later windows versions on the project site.

Alan

Change History (2)

comment:1 Changed 3 years ago by zubr

  • Owner set to zubr
  • Status changed from new to assigned

Problem confirmed. Will be fixed in next release.

comment:2 Changed 3 years ago by zubr

  • Resolution set to fixed
  • Status changed from assigned to closed

fixed in version 1.3

Note: See TracTickets for help on using tickets.